Vercel externals #3614
Vercel externals #3614
Conversation
🦋 Changeset detectedLatest commit: 86a7ea2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 86a7ea2 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f5b36c4e3de5000750b2fd |
packages/adapter-vercel/index.d.ts
Outdated
| import { Adapter } from '@sveltejs/kit'; | ||
|
|
||
| declare function plugin(): Adapter; | ||
| declare function plugin({ external }?: { external?: string[] }): Adapter; |
There was a problem hiding this comment.
I wonder if it's worth having the param as plugin(options?: Options) instead to simplify the type signature for intellisense, and conforms with the docs wording of "You can pass an options argument". But this PR is fine with the current type too.
There was a problem hiding this comment.
make sense, i made that change
fixes #3588, by adding an
externaloption that gets passed to esbuildPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0